Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2181013002: Revert of Cast device revocation checking. (Closed)

Created:
4 years, 5 months ago by Mark P
Modified:
4 years, 5 months ago
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, vadimgo+watch_chromium.org, dougsteed+watch_chromium.org, sheretov+watch_chromium.org, ryanchung+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cast device revocation checking. (patchset #26 id:500001 of https://codereview.chromium.org/2050983002/ ) Reason for revert: Causes failure on https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/31399 in components_unittests failures VerifyCastDeviceCertTest.ChromecastGen2InvalidTime VerifyCastDeviceCertTest.ChromecastGen2InvalidTime (run #1): [ RUN ] VerifyCastDeviceCertTest.ChromecastGen2InvalidTime ../../components/cast_certificate/cast_cert_validator_unittest.cc:99: Failure Value of: base::Time::FromUTCExploded(time, &result) Actual: false Expected: true [ FAILED ] VerifyCastDeviceCertTest.ChromecastGen2InvalidTime (13 ms) Original issue's description: > Cast device revocation checking. > > Cast device certificates may be revoked through two ways: > 1. The hash of the public key. > 2. A serial number range for an issuer identified by the hash > of its public key. > > A customized proto is used as the medium for this information. > > This change contains the implementation for verifying the custom CRL > and verifying a certificate's revocation status based on that CRL. > > BUG=618463 > > Committed: https://crrev.com/698608f28ed2df276f920c9691cbfcb8f9069337 > Cr-Commit-Position: refs/heads/master@{#407492} TBR=sheretov@chromium.org,eroman@chromium.org,asargent@chromium.org,davidben@chromium.org,ryanchung@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618463 Committed: https://crrev.com/3c7b546289d230828d59a97ac569d0f96a3cfd66 Cr-Commit-Position: refs/heads/master@{#407537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1296 lines) Patch
M chrome/common/extensions/api/networking_private/networking_private_crypto.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M components/cast_certificate.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
M components/cast_certificate/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M components/cast_certificate/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cast_certificate/cast_cert_validator.h View 5 chunks +10 lines, -25 lines 0 comments Download
M components/cast_certificate/cast_cert_validator.cc View 7 chunks +22 lines, -34 lines 0 comments Download
M components/cast_certificate/cast_cert_validator_test_helpers.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/cast_certificate/cast_cert_validator_test_helpers.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/cast_certificate/cast_cert_validator_unittest.cc View 3 chunks +7 lines, -10 lines 0 comments Download
D components/cast_certificate/cast_crl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/cast_certificate/cast_crl.cc View 1 chunk +0 lines, -340 lines 0 comments Download
D components/cast_certificate/cast_crl_root_ca_cert_der-inc.h View 1 chunk +0 lines, -8 lines 0 comments Download
D components/cast_certificate/cast_crl_unittest.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D components/cast_certificate/proto/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D components/cast_certificate/proto/revocation.proto View 1 chunk +0 lines, -60 lines 0 comments Download
D components/cast_certificate/proto/test_suite.proto View 1 chunk +0 lines, -56 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
D components/test/data/cast_certificate/certificates/cast_crl_test_root_ca.pem View 1 chunk +0 lines, -84 lines 0 comments Download
D components/test/data/cast_certificate/certificates/cast_test_root_ca.pem View 1 chunk +0 lines, -83 lines 0 comments Download
D components/test/data/cast_certificate/testsuite/README View 1 chunk +0 lines, -4 lines 0 comments Download
D components/test/data/cast_certificate/testsuite/testsuite1.pb View Binary file 0 comments Download
D components/test/data/cast_certificate/testsuite/testsuite1.pb_text View 1 chunk +0 lines, -219 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_auth_util.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mark P
Created Revert of Cast device revocation checking.
4 years, 5 months ago (2016-07-25 19:04:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181013002/1
4 years, 5 months ago (2016-07-25 19:05:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 19:06:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 19:12:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c7b546289d230828d59a97ac569d0f96a3cfd66
Cr-Commit-Position: refs/heads/master@{#407537}

Powered by Google App Engine
This is Rietveld 408576698