Chromium Code Reviews
DescriptionRemove death test in CompositorAnimationsTest
AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount
contains an EXPECT_DEATH test which checks that
CompositorAnimations::convertTimingForCompositor hits an assertion failure if
passed a Timing object with a value of -1 for iterationCount. This test is
probably included because -1 is a valid value for the equivalent field in the
output CompositorTiming object.
However, EXPECT_DEATH is flaky and dangerous in a multi-threaded context. Since
we're not gaining much by having this test, this patch removes it.
BUG=631021
Committed: https://crrev.com/0bc11b2ac870eb60d74f0f56337703ff6d4f1c80
Cr-Commit-Position: refs/heads/master@{#407674}
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|
|||||||||||||||||||