Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2180973003: Remove death test in CompositorAnimationsTest (Closed)

Created:
4 years, 4 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 4 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove death test in CompositorAnimationsTest AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount contains an EXPECT_DEATH test which checks that CompositorAnimations::convertTimingForCompositor hits an assertion failure if passed a Timing object with a value of -1 for iterationCount. This test is probably included because -1 is a valid value for the equivalent field in the output CompositorTiming object. However, EXPECT_DEATH is flaky and dangerous in a multi-threaded context. Since we're not gaining much by having this test, this patch removes it. BUG=631021 Committed: https://crrev.com/0bc11b2ac870eb60d74f0f56337703ff6d4f1c80 Cr-Commit-Position: refs/heads/master@{#407674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
suzyh_UTC10 (ex-contributor)
4 years, 4 months ago (2016-07-26 00:18:43 UTC) #3
alancutter (OOO until 2018)
lgtm
4 years, 4 months ago (2016-07-26 00:23:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180973003/1
4 years, 4 months ago (2016-07-26 00:29:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 01:27:26 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 01:29:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bc11b2ac870eb60d74f0f56337703ff6d4f1c80
Cr-Commit-Position: refs/heads/master@{#407674}

Powered by Google App Engine
This is Rietveld 408576698