[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter
* Making DownloadUIAdapter into SupportsUserData::Data available through OfflinePageModel

BUG=630817
Committed: https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558
Cr-Commit-Position: refs/heads/master@{#408981}

[fgorski, 2016-07-25 18:42:35]

fgorski@chromium.org changed reviewers:
+ dimich@chromium.org

[fgorski, 2016-07-25 18:42:36]

This is the other patch, that turns OfflinePageItem references to DownloadUIItem

[fgorski, 2016-07-26 22:12:14]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 22:12:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-07-26 22:13:42]

Description was changed from

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

BUG=
==========

to

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter 
* Exposing DownloadUIAdapter on OfflinePageModel (updating the interface of the
model)

BUG=630817
==========

[commit-bot: I haz the power, 2016-07-26 22:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 22:17:02]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fgorski, 2016-07-26 22:22:49]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2016-07-26 22:23:13]

PTAL (I am still working on DEPS/compilation), but the main thought is in.

https://codereview.chromium.org/2180973002/diff/40001/chrome/browser/android/...
File
chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
(right):

https://codereview.chromium.org/2180973002/diff/40001/chrome/browser/android/...
chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h:16:
using offline_pages::DownloadUIAdapter;
nit: remove this.

[commit-bot: I haz the power, 2016-07-26 22:23:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 22:28:07]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[fgorski, 2016-07-26 22:34:50]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 22:35:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 22:39:42]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fgorski, 2016-07-27 16:29:01]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 16:29:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-07-27 16:42:46]

Description was changed from

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter 
* Exposing DownloadUIAdapter on OfflinePageModel (updating the interface of the
model)

BUG=630817
==========

to

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter 
* Making DownloadUIAdapter into SupportsUserData::Data available through
OfflinePageModel

BUG=630817
==========

[commit-bot: I haz the power, 2016-07-27 17:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 17:25:39]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2016-07-27 22:04:35]

lgtm

[fgorski, 2016-07-28 16:27:32]

fgorski@chromium.org changed reviewers:
+ jochen@chromium.org

[fgorski, 2016-07-28 16:27:33]

Jochen, PTAL at the BUILD.gn

Thanks.

[jochen (gone - plz use gerrit), 2016-07-29 09:40:29]

lgtm

[fgorski, 2016-08-01 15:49:45]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-08-01 15:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 16:51:11]

Description was changed from

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter 
* Making DownloadUIAdapter into SupportsUserData::Data available through
OfflinePageModel

BUG=630817
==========

to

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter 
* Making DownloadUIAdapter into SupportsUserData::Data available through
OfflinePageModel

BUG=630817
==========

[commit-bot: I haz the power, 2016-08-01 16:51:12]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-01 16:55:04]

Description was changed from

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter 
* Making DownloadUIAdapter into SupportsUserData::Data available through
OfflinePageModel

BUG=630817
==========

to

==========
[Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter

* Wiring OfflinePageDownloadBridge to DownloadUIAdapter
* Making DownloadUIAdapter into SupportsUserData::Data available through
OfflinePageModel

BUG=630817

Committed: https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558
Cr-Commit-Position: refs/heads/master@{#408981}
==========

[commit-bot: I haz the power, 2016-08-01 16:55:05]

Patchset 7 (id:??) landed as
https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558
Cr-Commit-Position: refs/heads/master@{#408981}