Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2180963005: [Editing][Codehealth] Improve endOfParagraphAlgorithm readbility (Closed)

Created:
4 years, 4 months ago by yoichio
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][Codehealth] Improve endOfParagraphAlgorithm readbility Rename and sort variables, Extract function body to receive and return Position. TEST=No change in behavior Committed: https://crrev.com/12cafac224cb95ef48ff423f2f58a84872d74855 Cr-Commit-Position: refs/heads/master@{#407751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -44 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +48 lines, -44 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yoichio
4 years, 4 months ago (2016-07-26 07:50:50 UTC) #4
yoichio
4 years, 4 months ago (2016-07-26 08:11:41 UTC) #6
yosin_UTC9
lgtm Thanks for cleanup! (^_^)b
4 years, 4 months ago (2016-07-26 09:22:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180963005/1
4 years, 4 months ago (2016-07-26 09:23:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 09:40:26 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 09:42:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12cafac224cb95ef48ff423f2f58a84872d74855
Cr-Commit-Position: refs/heads/master@{#407751}

Powered by Google App Engine
This is Rietveld 408576698