Ensure fullscreen mode is exited for same-site navigations.

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include "base/command_line.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
@@ skipping 378 matching lines @@
             controller_->GetPendingEntry());
     if (!render_frame_host->frame_tree_node()->IsMainFrame() &&
         pending_entry &&
         pending_entry->frame_tree_node_id() ==
             render_frame_host->frame_tree_node()->frame_tree_node_id()) {
       params.transition = PAGE_TRANSITION_AUTO_SUBFRAME;
     }
   }
 
   if (PageTransitionIsMainFrame(params.transition)) {
-    // When overscroll navigation gesture is enabled, a screenshot of the page
-    // in its current state is taken so that it can be used during the
-    // nav-gesture. It is necessary to take the screenshot here, before calling
-    // RenderFrameHostManager::DidNavigateMainFrame, because that can change
-    // WebContents::GetRenderViewHost to return the new host, instead of the one
-    // that may have just been swapped out.
-    if (delegate_ && delegate_->CanOverscrollContent())
-      controller_->TakeScreenshot();
+    if (delegate_) {
+      // When overscroll navigation gesture is enabled, a screenshot of the page
+      // in its current state is taken so that it can be used during the
+      // nav-gesture. It is necessary to take the screenshot here, before
+      // calling RenderFrameHostManager::DidNavigateMainFrame, because that can
+      // change WebContents::GetRenderViewHost to return the new host, instead
+      // of the one that may have just been swapped out.
+      if (delegate_->CanOverscrollContent())
+        controller_->TakeScreenshot();

[Charlie Reis, 2014/04/01 23:12:38]

I agree that we shouldn't do it here, but I may move this stuff to
DidNavigateMainFramePreCommit in a future CL as well.

[miu, 2014/04/01 23:39:35]

Yeah, I almost did that.  ;-)  Feel free to use me as a code reviewer, or if I
notice it's still this way a few weeks from now, I might make the change.

+
+      // Run tasks that must execute just before the commit.
+      delegate_->DidNavigateMainFramePreCommit(params);
+    }
 
     if (!use_site_per_process)
       frame_tree->root()->render_manager()->DidNavigateFrame(render_frame_host);
   }
 
   // When using --site-per-process, we notify the RFHM for all navigations,
   // not just main frame navigations.
   if (use_site_per_process) {
     FrameTreeNode* frame = render_frame_host->frame_tree_node();
     frame->render_manager()->DidNavigateFrame(render_frame_host);
@@ skipping 169 matching lines @@
 
     // Navigations in Web UI pages count as browser-initiated navigations.
     params.is_renderer_initiated = false;
   }
 
   if (delegate_)
     delegate_->RequestOpenURL(render_frame_host, params);
 }
 
 }  // namespace content