MacViews: Change insertTextInternal to correctly handle IME character input.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 420 matching lines @@
   if ([text isKindOfClass:[NSAttributedString class]])
     text = [text string];
 
   bool isCharacterEvent = keyDownEvent_ && [text length] == 1;
 
   // Forward the |text| to |textInputClient_| if no menu is active.
   if (textInputClient_ && ![self activeMenuController]) {
     // If a single character is inserted by keyDown's call to
     // interpretKeyEvents: then use InsertChar() to allow editing events to be
     // merged.
-    if (isCharacterEvent)
-      textInputClient_->InsertChar(GetCharacterEventFromNSEvent(keyDownEvent_));
-    else
+    // Note we don't use |keyDownEvent_| to generate the synthetic ui::KeyEvent
+    // since for text inserted using an IME, [keyDownEvent_ characters] might
+    // not be the same as |text|. This is because |keyDownEvent_| will
+    // correspond to the event that caused the composition text to be confirmed,
+    // say, Return key press.
+    if (isCharacterEvent) {
+      textInputClient_->InsertChar(ui::KeyEvent([text characterAtIndex:0],
+                                                ui::VKEY_UNKNOWN, ui::EF_NONE));

[tapted, 2016/07/26 06:04:17]

Perhaps comment about VKEY_UNKNOWN?

E.g. before r400918, this used static_cast<ui::KeyboardCode>([text
characterAtIndex:0]) rather than ui::VKEY_UNKNOWN . Nicer than that is probably
to use one of the maps in keyboard_code_conversion_mac.mm . But if VKEY_UNKNOWN
covers all the use-cases, then that's OK.

[karandeepb, 2016/07/27 04:47:32]

Done. I guess this is fine, Else will have to expose KeyboardCodeFromCharCode
and even it has a fairly limited mapping.

+    } else {
       textInputClient_->InsertText(base::SysNSStringToUTF16(text));
+    }
     return;
   }
 
   // Only handle the case where no. of characters is 1. Cases not handled (not
   // an exhaustive list):
   // - |text| contains a unicode surrogate pair, i.e. a single grapheme which
   //   requires two 16 bit characters. Currently Views menu only supports
   //   mnemonics using a single 16 bit character, so it is ok to ignore this
   //   case.
   // - Programmatically created events.
@@ skipping 826 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end