Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2180853004: Revert of Restrict use of two app-launching command line flags (Closed)

Created:
4 years, 4 months ago by proberge
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restrict use of two app-launching command line flags (patchset #8 id:140001 of https://codereview.chromium.org/2108853002/ ) Reason for revert: Breaks official builds. chrome/browser/extensions/unpacked_installer.cc:43:12: error: unused variable 'kUnpackedExtensionInsteadOfAppError' Original issue's description: > Restrict use of two app-launching command line flags > > Mitigate abuse of the load-and-launch-app and load-apps flags by > disallowing loading of non-app extensions from these flags. > > For the official build, the flags no-op instead of showing an error popup > to avoid giving users with hijacked shortcuts a bad time (the error > message is shown then Chrome shuts down) > > BUG=624098 > > Committed: https://crrev.com/93c60cd3ef5908984e173112dc09345bb5714036 > Cr-Commit-Position: refs/heads/master@{#407824} TBR=rdevlin.cronin@chromium.org,asargent@chromium.org,msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624098 Committed: https://crrev.com/f50203526865893d6dc176e69f6a073116e5872b Cr-Commit-Position: refs/heads/master@{#407830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -92 lines) Patch
M apps/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M apps/app_load_service.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M apps/load_and_launch_browsertest.cc View 5 chunks +11 lines, -62 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 3 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
proberge
Created Revert of Restrict use of two app-launching command line flags
4 years, 4 months ago (2016-07-26 16:54:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180853004/1
4 years, 4 months ago (2016-07-26 16:55:05 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-07-26 16:55:07 UTC) #5
Cait (Slow)
lgtm
4 years, 4 months ago (2016-07-26 16:56:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180853004/1
4 years, 4 months ago (2016-07-26 16:56:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 16:58:01 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:00:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50203526865893d6dc176e69f6a073116e5872b
Cr-Commit-Position: refs/heads/master@{#407830}

Powered by Google App Engine
This is Rietveld 408576698