Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2180853003: DevTools: follow up to the widget hierarchy change, account for local widget reparending. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: follow up to the widget hierarchy change, account for local widget reparending. Committed: https://crrev.com/5f91146033477f83e46fcc821c263ffd7a13df76 Cr-Commit-Position: refs/heads/master@{#407705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/inspector/components/widget-events.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/widget-events-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 4 months ago (2016-07-26 01:59:30 UTC) #2
caseq
lgtm
4 years, 4 months ago (2016-07-26 02:02:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180853003/1
4 years, 4 months ago (2016-07-26 02:02:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 04:15:55 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 04:17:12 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f91146033477f83e46fcc821c263ffd7a13df76
Cr-Commit-Position: refs/heads/master@{#407705}

Powered by Google App Engine
This is Rietveld 408576698