Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js

Issue 2180843006: MD WebUI: Remove local DOM access from CrSearchFieldBehavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cr_search_field_clear
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var SearchField = Polymer({ 5 var SearchField = Polymer({
6 is: 'cr-search-field', 6 is: 'cr-search-field',
7 7
8 behaviors: [CrSearchFieldBehavior], 8 behaviors: [CrSearchFieldBehavior],
9 9
10 properties: { 10 properties: {
11 value_: String, 11 value_: String,
12 }, 12 },
13 13
14 /** @return {!HTMLInputElement} */
Dan Beam 2016/07/26 16:42:02 does /** @override */ work?
tsergeant 2016/07/26 23:32:49 No, Closure complains about overriding something t
Dan Beam 2016/07/26 23:36:54 bummer
15 getSearchInput: function() {
16 return this.$.searchInput;
17 },
18
14 /** @private */ 19 /** @private */
15 clearSearch_: function() { 20 clearSearch_: function() {
16 this.setValue(''); 21 this.setValue('');
17 this.$.searchInput.focus(); 22 this.getSearchInput().focus();
18 }, 23 },
19 24
20 /** @private */ 25 /** @private */
21 toggleShowingSearch_: function() { 26 toggleShowingSearch_: function() {
22 this.showingSearch = !this.showingSearch; 27 this.showingSearch = !this.showingSearch;
23 }, 28 },
24 }); 29 });
OLDNEW
« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698