Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2180843004: Use MemoryPressureListener in MemoryCoordinator (Closed)

Created:
4 years, 4 months ago by bashi
Modified:
4 years, 4 months ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MemoryPressureListener in MemoryCoordinator MemoryCoordinator sets its memory pressure notification dispatcher in the constructor and sets back to MemoryPressureListener::NotifyMemoryPressure() in the destructor. This seems weird. Using MemoryPressureListener instance makes things simpler. BUG=617492 Committed: https://crrev.com/a4d2261bf464657d1a4f1b27bb7a1f50f19d503f Cr-Commit-Position: refs/heads/master@{#407720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M components/memory_coordinator/browser/memory_coordinator.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/memory_coordinator/browser/memory_coordinator.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M components/memory_coordinator/browser/memory_coordinator_unittest.cc View 3 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bashi
This is a follow-up of https://codereview.chromium.org/2150783003/#msg44 Now MC depends on MPL and we won't kill ...
4 years, 4 months ago (2016-07-26 02:04:41 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-07-26 05:32:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180843004/1
4 years, 4 months ago (2016-07-26 05:56:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 05:59:35 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 06:00:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4d2261bf464657d1a4f1b27bb7a1f50f19d503f
Cr-Commit-Position: refs/heads/master@{#407720}

Powered by Google App Engine
This is Rietveld 408576698