Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2180843003: Flip misc. remaining Win FYI builders to GN. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis, brettw
CC:
chromium-reviews, alexmos, Ɓukasz Anforowicz, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_win_clang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip misc. remaining Win FYI builders to GN. This flips: - chromium.fyi - MD Top Chrome Win Material - Site Isolation Win - tryserver.chromium.win - win_nacl_sdk - win_nacl_sdk_build R=brettw@chromium.org, creis@chromium.org BUG=605318 Committed: https://crrev.com/032d2e7f0eb77552c1eed14f0dd22cb2accfcd94 Cr-Commit-Position: refs/heads/master@{#408007}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M tools/mb/mb_config.pyl View 1 5 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-25 23:05:53 UTC) #1
Charlie Reis
[CC alexmos, lukasza, site-isolation-reviews] Hooray! Site Isolation Win bot LGTM.
4 years, 4 months ago (2016-07-25 23:08:12 UTC) #2
brettw
lgtm
4 years, 4 months ago (2016-07-26 18:14:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180843003/1
4 years, 4 months ago (2016-07-26 22:31:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/41841) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-07-26 22:35:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180843003/20001
4 years, 4 months ago (2016-07-27 00:33:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 01:25:13 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 01:26:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/032d2e7f0eb77552c1eed14f0dd22cb2accfcd94
Cr-Commit-Position: refs/heads/master@{#408007}

Powered by Google App Engine
This is Rietveld 408576698