Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/bisect-perf-regression.py

Issue 218083002: [bisect] - Fix check for new v8 pushes to trunk from bleeding_edge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index e15cabe1cde820eafaacf25b01994a166378511c..9deeef3d551f20e2c5f16da6f85f56d7b3c4910a 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -1172,6 +1172,7 @@ class BisectPerformanceMetrics(object):
git_revision = self.source_control.ResolveToRevision(
bleeding_edge_revision, 'v8_bleeding_edge', 1,
cwd=v8_bleeding_edge_dir)
+ return git_revision
except IndexError, ValueError:
pass
@@ -1181,12 +1182,12 @@ class BisectPerformanceMetrics(object):
int(svn_revision) - 1, 'v8_bleeding_edge', -1,
cwd=v8_bleeding_edge_dir)
- if git_revision:
- revision_info = self.source_control.QueryRevisionInfo(git_revision,
- cwd=v8_bleeding_edge_dir)
+ if git_revision:
+ revision_info = self.source_control.QueryRevisionInfo(git_revision,
+ cwd=v8_bleeding_edge_dir)
- if 'Prepare push to trunk' in revision_info['subject']:
- return git_revision
+ if 'Prepare push to trunk' in revision_info['subject']:
+ return git_revision
return None
def _GetNearestV8BleedingEdgeFromTrunk(self, revision, search_forward=True):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698