Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 218083002: [bisect] - Fix check for new v8 pushes to trunk from bleeding_edge. (Closed)

Created:
6 years, 9 months ago by shatch
Modified:
6 years, 8 months ago
Reviewers:
prasadv, tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix check for new v8 pushes to trunk from bleeding_edge. So it turned out that the "Prepare push to trunk" isn't guaranteed anymore, so the new v8 mapping to bleeding edge wasn't quite right. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/bisect-perf-regression.py View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
shatch
6 years, 9 months ago (2014-03-29 02:39:02 UTC) #1
prasadv
lgtm
6 years, 8 months ago (2014-03-31 16:07:15 UTC) #2
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 8 months ago (2014-03-31 16:10:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/218083002/1
6 years, 8 months ago (2014-03-31 16:10:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 16:10:44 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-03-31 16:10:44 UTC) #6
shatch
ptal
6 years, 8 months ago (2014-04-02 23:14:34 UTC) #7
tonyg
lgtm
6 years, 8 months ago (2014-04-03 00:30:49 UTC) #8
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 8 months ago (2014-04-03 00:59:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/218083002/1
6 years, 8 months ago (2014-04-03 01:00:26 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 02:09:37 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-03 02:09:37 UTC) #12
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 8 months ago (2014-04-03 16:46:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/218083002/1
6 years, 8 months ago (2014-04-03 16:46:57 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:48:02 UTC) #15
Message was sent while issue was closed.
Change committed as 261449

Powered by Google App Engine
This is Rietveld 408576698