Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge conflicts with Tommy's CL. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index bc357a3f449716a8868ba5061d372076386a86a3..40d1040a23440e73f4e3bec607d071b865f98413 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -44,17 +44,6 @@ Polymer({
this.ContentSettingsTypes = settings.ContentSettingsTypes;
},
- /** @suppress {missingProperties} */
- attached: function() {
- settings.main.rendered.then(function() {
- if (this.showClearBrowsingDataDialog_) {
- var dialog = this.$$('settings-clear-browsing-data-dialog').$.dialog;
- // TODO(dbeam): cast to a CrDialogElement when it compiles.
- dialog.refit();
- }
- }.bind(this));
- },
-
/**
* @return {boolean} Whether the Clear Browsing Data dialog should be showing.
* @private
@@ -87,12 +76,8 @@ Polymer({
settings.navigateTo(settings.Route.CLEAR_BROWSER_DATA);
},
- /**
- * @param {!Event} event
- * @private
- */
- onIronOverlayClosed_: function(event) {
- if (Polymer.dom(event).rootTarget.tagName == 'CR-DIALOG')
- settings.navigateTo(settings.Route.PRIVACY);
+ /** @private */
+ onDialogClosed_: function() {
+ settings.navigateTo(settings.Route.PRIVACY);
},
});

Powered by Google App Engine
This is Rietveld 408576698