chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge conflicts with Tommy's CL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js b/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js

index c57d2f0b77c67d8d32faa96d7f652f37070be7ff..5471b5e382146f0e330e7e5135a22d8e7e086f65 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js

@@ -80,7 +80,7 @@ Polymer({

this.expirationYear = this.creditCard.expirationYear;

this.expirationMonth = this.creditCard.expirationMonth;

- this.$.dialog.open();

+ this.$.dialog.showModal();

/** Closes the dialog. */

@@ -93,7 +93,7 @@ Polymer({

* @private

onCancelButtonTap_: function() {

- this.close();

+ this.$.dialog.cancel();

/**