Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4174)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge conflicts with Tommy's CL. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
index 82b19f45040b409029bcf19a6238b77fca9a10e7..7159694c54a1dc152aa554d5ca93e8557e926a6a 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
@@ -107,14 +107,12 @@ Polymer({
* @suppress {missingProperties}
*/
(function() {
- self.$.dialog.notifyResize();
-
self.updateCanSave_();
self.fire('on-update-address-wrapper'); // For easier testing.
- if (!self.$.dialog.opened)
- self.$.dialog.open();
+ if (!self.$.dialog.open)
+ self.$.dialog.showModal();
})();
});
},
@@ -161,6 +159,11 @@ Polymer({
return !country.countryCode;
},
+ /** @private */
+ onCancelTap_: function() {
+ this.$.dialog.cancel();
+ },
+
/**
* Handler for tapping the save button.
* @private

Powered by Google App Engine
This is Rietveld 408576698