chrome/browser/resources/settings/about_page/channel_switcher_dialog.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/channel_switcher_dialog.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge conflicts with Tommy's CL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/about_page/channel_switcher_dialog.html ('k') | chrome/browser/resources/settings/about_page/detailed_build_info.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/channel_switcher_dialog.js

diff --git a/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js b/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js

index 4b911c1904017b4b125da2510bca62bca4e46cb6..14b01f6677b5be6df406e3ea2798c0417a497af0 100644

--- a/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js

+++ b/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js

@@ -55,7 +55,7 @@ Polymer({

/** @override */

attached: function() {

- this.$.dialog.open();

+ this.$.dialog.showModal();

/** @private */

@@ -121,7 +121,6 @@ Polymer({

if (selectedChannel == this.currentChannel_) {

this.shouldShowButtons_ = null;

this.warning_ = null;

- this.$.dialog.notifyResize();

return;

}

@@ -145,7 +144,6 @@ Polymer({

'aboutProductTitle');

this.updateButtons_(true, false);

}

- this.$.dialog.notifyResize();

/**