chrome/browser/resources/settings/search_engines_page/search_engines_page.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.js ('k') | chrome/browser/resources/settings/site_settings/add_site_dialog.html » ('j') | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

index 7fe11631b62a6f3dc8fc99751eaf7f0d6a0b700f..d8c7b6fc81a3be89ec9f1e4d9a226cb29f46e388 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

@@ -66,7 +66,7 @@ Polymer({

// Register listener to detect when the dialog is closed. Flip the boolean

// once closed to force a restamp next time it is shown such that the

// previous dialog's contents are cleared.

- dialog.addEventListener('iron-overlay-closed', function() {

+ dialog.addEventListener('close', function() {

this.showAddSearchEngineDialog_ = false;

}.bind(this));