chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.js ('k') | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js » ('j') | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

index b471c22d415e4c77058627b2533f04a74894126d..97b3e81db977a641577c40bb603d9f6de0fc3afd 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

@@ -107,7 +107,7 @@

<!-- #notice correctly places its own backdrop above #dialog and under

itself, so when it is shown, #dialog should not use backdrop. -->

- <cr-dialog id="dialog" with-backdrop="[[!showHistoryDeletionDialog_]]">

+ <dialog is="cr-dialog" id="dialog" with-backdrop="[[!showHistoryDeletionDialog_]]">

<div class="title">$i18n{clearBrowsingData}</div>

@@ -163,7 +163,7 @@

<paper-spinner active="[[clearingInProgress_]]"></paper-spinner>

<paper-button class="cancel-button" disabled="[[clearingInProgress_]]"

- dialog-dismiss>$i18n{cancel}</paper-button>

+ on-tap="onCancelTap_">$i18n{cancel}</paper-button>

<paper-button class="action-button" disabled="[[clearingInProgress_]]"

on-tap="onClearBrowsingDataTap_">

$i18n{clearBrowsingData}

@@ -185,7 +185,7 @@

</div>

- </cr-dialog>

+ </dialog>

<settings-history-deletion-dialog id="notice"