chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Populating |returnValue|. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html ('k') | chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js

diff --git a/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js b/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js

index 08de7fa22f40107586c5e7665192649b8cabac23..42ebcf5fc6425fe060e8de1346561343e32064a7 100644

--- a/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js

+++ b/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js

@@ -42,11 +42,18 @@ Polymer({

this.browserProxy_.getCaCertificateTrust(this.model.id).then(

/** @param {!CaTrustInfo} trustInfo */

function(trustInfo) {

+ if (!this.isAttached) {

+ // This element might have been detached from the DOM during the

+ // async operation (happens in testing code). Do not attempt to

+ // open the dialog in such case.

+ return;

+ }

this.trustInfo_ = trustInfo;

- this.$.dialog.open();

+ this.$.dialog.showModal();

}.bind(this));

} else {

- /** @type {!CrDialogElement} */ (this.$.dialog).open();

+ /** @type {!CrDialogElement} */ (this.$.dialog).showModal();

}