Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome/browser/resources/settings/about_page/detailed_build_info.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge conflicts with Tommy's CL. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-detailed-build-info' contains detailed build 6 * @fileoverview 'settings-detailed-build-info' contains detailed build
7 * information for ChromeOS. 7 * information for ChromeOS.
8 */ 8 */
9 9
10 Polymer({ 10 Polymer({
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 /** @private */ 58 /** @private */
59 onChangeChannelTap_: function() { 59 onChangeChannelTap_: function() {
60 this.showChannelSwitcherDialog_ = true; 60 this.showChannelSwitcherDialog_ = true;
61 // Async to wait for dialog to appear in the DOM. 61 // Async to wait for dialog to appear in the DOM.
62 this.async(function() { 62 this.async(function() {
63 var dialog = this.$$('settings-channel-switcher-dialog'); 63 var dialog = this.$$('settings-channel-switcher-dialog');
64 // Register listener to detect when the dialog is closed. Flip the boolean 64 // Register listener to detect when the dialog is closed. Flip the boolean
65 // once closed to force a restamp next time it is shown such that the 65 // once closed to force a restamp next time it is shown such that the
66 // previous dialog's contents are cleared. 66 // previous dialog's contents are cleared.
67 dialog.addEventListener('iron-overlay-closed', function() { 67 dialog.addEventListener('close', function() {
68 this.showChannelSwitcherDialog_ = false; 68 this.showChannelSwitcherDialog_ = false;
69 }.bind(this)); 69 }.bind(this));
70 }.bind(this)); 70 }.bind(this));
71 }, 71 },
72 }); 72 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698