Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-behavior.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-shared-styles.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
7 5
8 <dom-module id="cr-dialog"> 6 <dom-module id="cr-dialog">
9 <template> 7 <template>
10 <style include="paper-dialog-shared-styles"> 8 <style>
11 :host { 9 :host {
10 border: 0;
12 border-radius: 2px; 11 border-radius: 2px;
12 bottom: 0;
13 color: inherit;
14 padding: 0;
15 top: 0;
13 } 16 }
14 17
15 :host ::content > * { 18 :host::backdrop {
16 /* Overrides paper-dialog-shared-styles. */ 19 background-color: rgba(0, 0, 0, 0.6);
17 -webkit-padding-end: 0; 20 bottom: 0;
18 -webkit-padding-start: 0; 21 left: 0;
19 margin-bottom: 0; 22 position: fixed;
20 margin-top: 0; 23 right: 0;
24 top: 0;
21 } 25 }
22 26
23 .title-container { 27 .title-container {
24 align-items: center; 28 align-items: center;
25 /* TODO(dbeam): should this be a --settings-separator-line? */ 29 /* TODO(dbeam): should this be a --settings-separator-line? */
26 border-bottom: 1px solid rgba(0, 0, 0, 0.14); 30 border-bottom: 1px solid rgba(0, 0, 0, 0.14);
27 display: flex; 31 display: flex;
28 min-height: 52px; 32 min-height: 52px;
29 } 33 }
30 34
31 :host ::content .title { 35 :host ::content .title {
32 font-size: 114.28%; /* (16px / 14px) * 100 */ 36 font-size: 123.07%; /* (16px / 13px) * 100 */
33 } 37 }
34 38
35 #close { 39 #close {
36 --paper-icon-button: { 40 --paper-icon-button: {
37 height: 40px; 41 height: 40px;
38 width: 40px; 42 width: 40px;
39 }; 43 };
40 -webkit-margin-end: 6px; 44 -webkit-margin-end: 6px;
41 /* <paper-icon-button> overrides --iron-icon-{height,width}, so this 45 /* <paper-icon-button> overrides --iron-icon-{height,width}, so this
42 * padding essentially reduces 40x40 to 20x20. */ 46 * padding essentially reduces 40x40 to 20x20. */
(...skipping 13 matching lines...) Expand all
56 margin: 12px 0; 60 margin: 12px 0;
57 } 61 }
58 62
59 :host ::content .body, 63 :host ::content .body,
60 :host ::content .title { 64 :host ::content .title {
61 -webkit-padding-end: 24px; 65 -webkit-padding-end: 24px;
62 -webkit-padding-start: 24px; 66 -webkit-padding-start: 24px;
63 flex: 1; 67 flex: 1;
64 } 68 }
65 69
66 :host ::content .body,
67 :host ::content .footer,
68 :host ::content paper-button {
69 font-size: 92.86%; /* (13px / 14px) * 100 */
70 }
71
72 :host ::content .button-container { 70 :host ::content .button-container {
73 -webkit-padding-end: 16px; 71 -webkit-padding-end: 16px;
74 -webkit-padding-start: 16px; 72 -webkit-padding-start: 16px;
75 display: flex; 73 display: flex;
76 justify-content: flex-end; 74 justify-content: flex-end;
77 margin-bottom: 12px; 75 margin-bottom: 12px;
78 margin-top: 12px; 76 margin-top: 12px;
79 } 77 }
80 78
81 :host ::content .button-container .cancel-button { 79 :host ::content .button-container .cancel-button {
(...skipping 15 matching lines...) Expand all
97 </paper-icon-button> 95 </paper-icon-button>
98 </div> 96 </div>
99 <div class="body-container"> 97 <div class="body-container">
100 <content select=".body"></content> 98 <content select=".body"></content>
101 </div> 99 </div>
102 <content select=".button-container"></content> 100 <content select=".button-container"></content>
103 <content select=".footer"></content> 101 <content select=".footer"></content>
104 </template> 102 </template>
105 <script src="cr_dialog.js"></script> 103 <script src="cr_dialog.js"></script>
106 </dom-module> 104 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698