Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

chrome/test/data/webui/settings/certificate_manager_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('certificate_manager_page', function() {
   /**
    * A test version of CertificatesBrowserProxy. Provides helper methods
    * for allowing tests to know when a method was called, as well as
    * specifying mock responses.
    *
@@ skipping 226 matching lines @@
 
               return browserProxy.whenCalled('editCaCertificateTrust');
             }).then(function(args) {
               assertEquals(dialog.model.id, args.id);
               // Checking that the values sent to C++ are reflecting the
               // changes made by the user (toggling all checkboxes).
               assertEquals(caTrustInfo.ssl, !args.ssl);
               assertEquals(caTrustInfo.email, !args.email);
               assertEquals(caTrustInfo.objSign, !args.objSign);
               // Check that the dialog is closed.
-              assertFalse(dialog.$.dialog.opened);
+              assertFalse(dialog.$.dialog.open);
             });
       });
 
       test('ImportSuccess', function() {
         dialog.model = {name: 'Dummy certificate name'};
         document.body.appendChild(dialog);
 
         assertFalse(dialog.$.ssl.checked);
         assertFalse(dialog.$.email.checked);
         assertFalse(dialog.$.objSign.checked);
@@ skipping 48 matching lines @@
         dialog = document.createElement(
             'settings-certificate-delete-confirmation-dialog');
         dialog.model = model;
         dialog.certificateType = CertificateType.PERSONAL;
         document.body.appendChild(dialog);
       });
 
       teardown(function() { dialog.remove(); });
 
       test('DeleteSuccess', function() {
-        assertTrue(dialog.$.dialog.opened);
+        assertTrue(dialog.$.dialog.open);
         // Check that the dialog title includes the certificate name.
         var titleEl = Polymer.dom(dialog.$.dialog).querySelector('.title');
         assertTrue(titleEl.textContent.includes(model.name));
 
         // Simulate clicking 'OK'.
         MockInteractions.tap(dialog.$.ok);
 
         return browserProxy.whenCalled('deleteCertificate').then(
             function(id) {
               assertEquals(model.id, id);
               // Check that the dialog is closed.
-              assertFalse(dialog.$.dialog.opened);
+              assertFalse(dialog.$.dialog.open);
             });
       });
 
       test('DeleteError', function() {
         browserProxy.forceCertificatesError();
         var whenErrorEventFired = eventToPromise('certificates-error', dialog);
 
         // Simulate clicking 'OK'.
         MockInteractions.tap(dialog.$.ok);
         return browserProxy.whenCalled('deleteCertificate').then(
@@ skipping 30 matching lines @@
       });
 
       teardown(function() { dialog.remove(); });
 
       test('EncryptSuccess', function() {
         var passwordInputElements =
             Polymer.dom(dialog.$.dialog).querySelectorAll('paper-input');
         var passwordInputElement = passwordInputElements[0];
         var confirmPasswordInputElement = passwordInputElements[1];
 
-        assertTrue(dialog.$.dialog.opened);
+        assertTrue(dialog.$.dialog.open);
         assertTrue(dialog.$.ok.disabled);
 
         // Test that the 'OK' button is disabled when the password fields are
         // empty (even though they both have the same value).
         triggerInputEvent(passwordInputElement);
         assertTrue(dialog.$.ok.disabled);
 
         // Test that the 'OK' button is disabled until the two password fields
         // match.
         passwordInputElement.value = 'foopassword';
         triggerInputEvent(passwordInputElement);
         assertTrue(dialog.$.ok.disabled);
         confirmPasswordInputElement.value = passwordInputElement.value;
         triggerInputEvent(confirmPasswordInputElement);
         assertFalse(dialog.$.ok.disabled);
 
         // Simulate clicking 'OK'.
         MockInteractions.tap(dialog.$.ok);
 
         return browserProxy.whenCalled(methodName).then(function(password) {
           assertEquals(passwordInputElement.value, password);
           // Check that the dialog is closed.
-          assertFalse(dialog.$.dialog.opened);
+          assertFalse(dialog.$.dialog.open);
         });
       });
 
       test('EncryptError', function() {
         browserProxy.forceCertificatesError();
 
         var passwordInputElements =
             Polymer.dom(dialog.$.dialog).querySelectorAll('paper-input');
         var passwordInputElement = passwordInputElements[0];
         passwordInputElement.value = 'foopassword';
@@ skipping 28 matching lines @@
         dialog = document.createElement(
             'settings-certificate-password-decryption-dialog');
         document.body.appendChild(dialog);
       });
 
       teardown(function() { dialog.remove(); });
 
       test('DecryptSuccess', function() {
         var passwordInputElement =
             Polymer.dom(dialog.$.dialog).querySelector('paper-input');
-        assertTrue(dialog.$.dialog.opened);
+        assertTrue(dialog.$.dialog.open);
         assertTrue(dialog.$.ok.disabled);
 
         // Test that the 'OK' button is disabled when the password field is
         // empty.
         triggerInputEvent(passwordInputElement);
         assertTrue(dialog.$.ok.disabled);
         passwordInputElement.value = 'foopassword';
         triggerInputEvent(passwordInputElement);
         assertFalse(dialog.$.ok.disabled);
 
         // Simulate clicking 'OK'.
         MockInteractions.tap(dialog.$.ok);
 
         return browserProxy.whenCalled(methodName).then(function(password) {
           assertEquals(passwordInputElement.value, password);
           // Check that the dialog is closed.
-          assertFalse(dialog.$.dialog.opened);
+          assertFalse(dialog.$.dialog.open);
         });
       });
 
       test('DecryptError', function() {
         browserProxy.forceCertificatesError();
         // Simulate entering some password.
         var passwordInputElement =
             Polymer.dom(dialog.$.dialog).querySelector('paper-input');
         passwordInputElement.value = 'foopassword';
         triggerInputEvent(passwordInputElement);
@@ skipping 14 matching lines @@
     var browserProxy = null;
 
     /**
      * @return {!Promise} A promise firing once a
      *     |settings.CertificateActionEvent| fires.
      */
     var actionEventToPromise = function() {
       return eventToPromise(settings.CertificateActionEvent, subentry);
     };
 
-    suite('CertificateManagerPageTests', function() {
+    suite('CertificateSubentryTests', function() {
       setup(function() {
         browserProxy = new TestCertificatesBrowserProxy();
         settings.CertificatesBrowserProxyImpl.instance_ = browserProxy;
         PolymerTest.clearBody();
         subentry = document.createElement('settings-certificate-subentry');
         subentry.model = createSampleCertificateSubnode();
         subentry.certificateType = CertificateType.PERSONAL;
         document.body.appendChild(subentry);
 
         // Bring up the popup menu for the following tests to use.
@@ skipping 192 matching lines @@
               assertCertificateListLength(CertificateCategoryIndex.CA, 2);
               assertCertificateListLength(CertificateCategoryIndex.OTHER, 0);
             });
       });
 
       /**
        * Tests that a dialog opens as a response to a
        * settings.CertificateActionEvent.
        * @param {string} dialogTagName The type of dialog to test.
        * @param {CertificateActionEventDetail} eventDetail
+       * @return {!Promise}
        */
       function testDialogOpensOnAction(dialogTagName, eventDetail)  {
         assertFalse(!!page.shadowRoot.querySelector(dialogTagName));
         page.fire(settings.CertificateActionEvent, eventDetail);
         Polymer.dom.flush();
-        assertTrue(!!page.shadowRoot.querySelector(dialogTagName));
+        var dialog = page.shadowRoot.querySelector(dialogTagName);
+        assertTrue(!!dialog);
+
+        if (dialog.$.dialog.open)
+          return Promise.resolve();
+
+        // Some dialogs are opened after some async operation to fetch initial
+        // data. Ensure that the underlying cr-dialog is actually opened by
+        // listening for changes for the 'open' attribute.
+        return new Promise(function(resolve, reject) {
+          var observer = new MutationObserver(function(mutations) {

[Dan Beam, 2016/07/28 19:09:35]

mind == blown

[dpapad, 2016/07/28 19:29:31]

Ack!

+            assertEquals(1, mutations.length);
+            assertEquals('attributes', mutations[0].type);
+            assertEquals('open', mutations[0].attributeName);
+            observer.disconnect();
+            resolve();
+          });
+          observer.observe(
+              dialog.$.dialog,
+              {attributes: true, childList: false, characterData: false});
+        });
       }
 
       test('OpensDialog_DeleteConfirmation', function() {
-        testDialogOpensOnAction(
+        return testDialogOpensOnAction(
             'settings-certificate-delete-confirmation-dialog',
             /** @type {!CertificateActionEventDetail} */ ({
               action: CertificateAction.DELETE,
               subnode: createSampleCertificateSubnode(),
               certificateType: CertificateType.PERSONAL
             }));
       });
 
       test('OpensDialog_PasswordEncryption', function() {
-        testDialogOpensOnAction(
+        return testDialogOpensOnAction(
             'settings-certificate-password-encryption-dialog',
             /** @type {!CertificateActionEventDetail} */ ({
               action: CertificateAction.EXPORT_PERSONAL,
               subnode: createSampleCertificateSubnode(),
               certificateType: CertificateType.PERSONAL
             }));
       });
 
       test('OpensDialog_PasswordDecryption', function() {
-        testDialogOpensOnAction(
+        return testDialogOpensOnAction(
             'settings-certificate-password-decryption-dialog',
             /** @type {!CertificateActionEventDetail} */ ({
               action: CertificateAction.IMPORT,
               subnode: createSampleCertificateSubnode(),
               certificateType: CertificateType.PERSONAL
             }));
       });
 
       test('OpensDialog_CaTrustEdit', function() {
-        testDialogOpensOnAction(
+        return testDialogOpensOnAction(
             'settings-ca-trust-edit-dialog',
             /** @type {!CertificateActionEventDetail} */ ({
               action: CertificateAction.EDIT,
               subnode: createSampleCertificateSubnode(),
               certificateType: CertificateType.CA
             }));
       });
 
       test('OpensDialog_CaTrustImport', function() {
-        testDialogOpensOnAction(
+        return testDialogOpensOnAction(
             'settings-ca-trust-edit-dialog',
             /** @type {!CertificateActionEventDetail} */ ({
               action: CertificateAction.IMPORT,
               subnode: {name: 'Dummy Certificate Name', id: null},
               certificateType: CertificateType.CA
             }));
       });
     });
   }
 
@@ skipping 72 matching lines @@
       registerCaTrustEditDialogTests();
       registerDeleteDialogTests();
       registerPasswordEncryptDialogTests();
       registerPasswordDecryptDialogTests();
       registerPageTests();
       registerCertificateSubentryTests();
       registerCertificateListTests();
     },
   };
 });