Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/resources/settings/reset_page/reset_page.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-reset-page' is the settings page containing reset 7 * 'settings-reset-page' is the settings page containing reset
8 * settings. 8 * settings.
9 * 9 *
10 * Example: 10 * Example:
(...skipping 28 matching lines...) Expand all
39 /** 39 /**
40 * Creates and shows the specified dialog. 40 * Creates and shows the specified dialog.
41 * @param {string} dialogName 41 * @param {string} dialogName
42 * @private 42 * @private
43 */ 43 */
44 showDialog_: function(dialogName) { 44 showDialog_: function(dialogName) {
45 var dialog = document.createElement(dialogName); 45 var dialog = document.createElement(dialogName);
46 this.shadowRoot.appendChild(dialog); 46 this.shadowRoot.appendChild(dialog);
47 dialog.open(); 47 dialog.open();
48 48
49 dialog.addEventListener('iron-overlay-closed', function() { 49 dialog.addEventListener('close', function() {
50 dialog.remove(); 50 dialog.remove();
51 }); 51 });
52 }, 52 },
53 }); 53 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698