Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2180803003: Add macro definition __CHROMEOS__ for ChromeOS builds in GYP. (Closed)

Created:
4 years, 4 months ago by Ting-Yuan (Leo) Huang
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add macro definition __CHROMEOS__ for ChromeOS builds in GYP. This is needed for clients that need to address some special behaviors of ChromeOS. This is intended to be a cherry-pick for older releases, where GYP is used BUG=chromium:628040 Committed: https://crrev.com/b655d0a1b0ea8cf0dc8e29ee650c8a55b79337d1 Cr-Commit-Position: refs/heads/master@{#407630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M breakpad/breakpad.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
laszio
4 years, 4 months ago (2016-07-25 22:09:30 UTC) #2
laszio
4 years, 4 months ago (2016-07-25 22:33:40 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-07-25 22:43:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180803003/1
4 years, 4 months ago (2016-07-25 23:26:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 23:30:47 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 23:33:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b655d0a1b0ea8cf0dc8e29ee650c8a55b79337d1
Cr-Commit-Position: refs/heads/master@{#407630}

Powered by Google App Engine
This is Rietveld 408576698