Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: chrome/browser/permissions/permission_util.h

Issue 2180723002: Add revocation metrics from OIB and content setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@revocation-reporter
Patch Set: Remove set custom host map Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_util.h
diff --git a/chrome/browser/permissions/permission_util.h b/chrome/browser/permissions/permission_util.h
index b63b2e084485bf9b157a7809fd4a0e049d34af81..54bb9cdaa0c4f22847ffa6ad332e77a5429427da 100644
--- a/chrome/browser/permissions/permission_util.h
+++ b/chrome/browser/permissions/permission_util.h
@@ -41,7 +41,9 @@ class PermissionUtil {
// A scoped class that will check the current resolved content setting on
// construction and report a revocation metric accordingly if the revocation
- // condition is met (from ALLOW to something else).
+ // condition is met (from ALLOW to something else). By default,
+ // |settings_map_| is obtained from |profile_|, but it can be changed with the
+ // setter if necessary.
raymes 2016/07/26 07:50:03 This comment is incorrect now
stefanocs 2016/07/26 12:00:05 Done.
class ScopedRevocationReporter {
public:
ScopedRevocationReporter(Profile* profile,
@@ -50,6 +52,12 @@ class PermissionUtil {
ContentSettingsType content_type,
PermissionSourceUI source_ui);
+ ScopedRevocationReporter(Profile* profile,
+ const ContentSettingsPattern& primary_pattern,
+ const ContentSettingsPattern& secondary_pattern,
+ ContentSettingsType content_type,
+ PermissionSourceUI source_ui);
+
~ScopedRevocationReporter();
private:
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_util.cc » ('j') | chrome/browser/ui/website_settings/website_settings.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698