Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2180723002: Add revocation metrics from OIB and content setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@revocation-reporter
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/website_settings.h" 5 #include "chrome/browser/ui/website_settings/website_settings.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 histogram_value, num_values); 280 histogram_value, num_values);
281 281
282 if (setting == ContentSetting::CONTENT_SETTING_ALLOW) { 282 if (setting == ContentSetting::CONTENT_SETTING_ALLOW) {
283 UMA_HISTOGRAM_ENUMERATION( 283 UMA_HISTOGRAM_ENUMERATION(
284 "WebsiteSettings.OriginInfo.PermissionChanged.Allowed", histogram_value, 284 "WebsiteSettings.OriginInfo.PermissionChanged.Allowed", histogram_value,
285 num_values); 285 num_values);
286 } else if (setting == ContentSetting::CONTENT_SETTING_BLOCK) { 286 } else if (setting == ContentSetting::CONTENT_SETTING_BLOCK) {
287 UMA_HISTOGRAM_ENUMERATION( 287 UMA_HISTOGRAM_ENUMERATION(
288 "WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value, 288 "WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value,
289 num_values); 289 num_values);
290 // Trigger Rappor sampling if it is a permission revoke action.
291 // TODO(tsergeant): Integrate this with the revocation recording performed
292 // in the permissions layer. See crbug.com/469221.
293 content::PermissionType permission_type;
294 if (PermissionUtil::GetPermissionType(type, &permission_type)) {
295 PermissionUmaUtil::PermissionRevoked(permission_type,
296 PermissionSourceUI::OIB,
297 this->site_url_, this->profile_);
298 }
299 } 290 }
300 291
301 // This is technically redundant given the histogram above, but putting the 292 // This is technically redundant given the histogram above, but putting the
302 // total count of permission changes in another histogram makes it easier to 293 // total count of permission changes in another histogram makes it easier to
303 // compare it against other kinds of actions in WebsiteSettings[PopupView]. 294 // compare it against other kinds of actions in WebsiteSettings[PopupView].
304 RecordWebsiteSettingsAction(WEBSITE_SETTINGS_CHANGED_PERMISSION); 295 RecordWebsiteSettingsAction(WEBSITE_SETTINGS_CHANGED_PERMISSION);
305 296
297 PermissionUtil::ScopedRevocationReporter scoped_revocation_reporter(
298 this->profile_, this->site_url_, this->site_url_, type,
299 PermissionSourceUI::OIB);
300
306 content_settings_->SetNarrowestContentSetting(site_url_, site_url_, type, 301 content_settings_->SetNarrowestContentSetting(site_url_, site_url_, type,
307 setting); 302 setting);
308 303
309 show_info_bar_ = true; 304 show_info_bar_ = true;
310 305
311 // Refresh the UI to reflect the new setting. 306 // Refresh the UI to reflect the new setting.
312 PresentSitePermissions(); 307 PresentSitePermissions();
313 } 308 }
314 309
315 void WebsiteSettings::OnSiteChosenObjectDeleted( 310 void WebsiteSettings::OnSiteChosenObjectDeleted(
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 info.connection_status = site_connection_status_; 757 info.connection_status = site_connection_status_;
763 info.connection_status_description = 758 info.connection_status_description =
764 UTF16ToUTF8(site_connection_details_); 759 UTF16ToUTF8(site_connection_details_);
765 info.identity_status = site_identity_status_; 760 info.identity_status = site_identity_status_;
766 info.identity_status_description = 761 info.identity_status_description =
767 UTF16ToUTF8(site_identity_details_); 762 UTF16ToUTF8(site_identity_details_);
768 info.cert_id = cert_id_; 763 info.cert_id = cert_id_;
769 info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_; 764 info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
770 ui_->SetIdentityInfo(info); 765 ui_->SetIdentityInfo(info);
771 } 766 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_util_unittest.cc ('k') | chrome/browser/ui/webui/options/content_settings_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698