Add revocation metrics from OIB and content setting

chrome/browser/ui/website_settings/website_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/website_settings.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 270 matching lines @@
                             histogram_value, num_values);
 
   if (setting == ContentSetting::CONTENT_SETTING_ALLOW) {
     UMA_HISTOGRAM_ENUMERATION(
         "WebsiteSettings.OriginInfo.PermissionChanged.Allowed", histogram_value,
         num_values);
   } else if (setting == ContentSetting::CONTENT_SETTING_BLOCK) {
     UMA_HISTOGRAM_ENUMERATION(
         "WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value,
         num_values);
-    // Trigger Rappor sampling if it is a permission revoke action.
-    // TODO(tsergeant): Integrate this with the revocation recording performed

[kcarattini, 2016/07/26 03:54:20]

Tim, is this TODO completed now? I'm not really sure what you meant by it.

[tsergeant, 2016/07/26 04:09:30]

Yup, it's also done. It's referring to using the same PermissionUtil revocation
helper here as everywhere else.

-    // in the permissions layer. See crbug.com/469221.
-    content::PermissionType permission_type;
-    if (PermissionUtil::GetPermissionType(type, &permission_type)) {
-      PermissionUmaUtil::PermissionRevoked(permission_type,
-                                           PermissionSourceUI::OIB,
-                                           this->site_url_, this->profile_);
-    }
   }
 
   // This is technically redundant given the histogram above, but putting the
   // total count of permission changes in another histogram makes it easier to
   // compare it against other kinds of actions in WebsiteSettings[PopupView].
   RecordWebsiteSettingsAction(WEBSITE_SETTINGS_CHANGED_PERMISSION);
 
+  PermissionUtil::ScopedRevocationReporter scoped_revocation_reporter(
+      this->profile_, this->site_url_, this->site_url_, type,
+      PermissionSourceUI::OIB);
+
   content_settings_->SetNarrowestContentSetting(site_url_, site_url_, type,
                                                 setting);
 
   show_info_bar_ = true;
 
   // Refresh the UI to reflect the new setting.
   PresentSitePermissions();
 }
 
 void WebsiteSettings::OnSiteChosenObjectDeleted(
@@ skipping 446 matching lines @@
   info.connection_status = site_connection_status_;
   info.connection_status_description =
       UTF16ToUTF8(site_connection_details_);
   info.identity_status = site_identity_status_;
   info.identity_status_description =
       UTF16ToUTF8(site_identity_details_);
   info.cert_id = cert_id_;
   info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
   ui_->SetIdentityInfo(info);
 }