Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2180683003: NOSUBMIT: PointerWatcher observes all pointer events, with moves optional (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOSUBMIT: PointerWatcher observes all pointer events, with moves optional * Introduce StartPointerWatcher / StopPointerWatcher in WindowTree mojom interface * Remove TouchEventWatcher * Use PointerWatcher in touch HUD app * Eliminate EventMatcher use with PointerWatcher TODO: Rename EventMatcher to KeyEventMatcher and eliminate pointer-kind? BUG=628663 TEST=views_mus_unittests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -367 lines) Patch
M ash/common/shelf/overflow_bubble.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/common/shelf/overflow_bubble.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M ash/common/system/tray/tray_event_filter.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/common/system/tray/tray_event_filter.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M ash/pointer_watcher_delegate_aura.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M ash/sysui/pointer_watcher_delegate_mus.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M services/ui/public/cpp/lib/window_tree_client.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.h View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/public/cpp/tests/window_tree_client_private.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/public/cpp/tests/window_tree_client_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 2 chunks +7 lines, -6 lines 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.h View 3 chunks +14 lines, -5 lines 0 comments Download
M services/ui/ws/window_tree.cc View 2 chunks +27 lines, -45 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 4 chunks +2 lines, -7 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 5 chunks +24 lines, -61 lines 0 comments Download
M ui/views/mus/window_manager_connection_unittest.cc View 6 chunks +9 lines, -107 lines 0 comments Download
M ui/views/pointer_watcher.h View 2 chunks +8 lines, -8 lines 0 comments Download
D ui/views/touch_event_watcher.h View 1 chunk +0 lines, -43 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views_exports.cc View 1 chunk +0 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698