Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2180653002: Attempt to fix Mac ASAN build in GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix Mac ASAN build in GN. This patch adjusts the rpath used for the ASAN runtime libraries on the mac so that they will work with bundled apps as well as simple executables. R=rsesek@chromium.org BUG=630322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M build/config/mac/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M build/config/sanitizers/BUILD.gn View 2 chunks +8 lines, -3 lines 0 comments Download
A build/config/sanitizers/copy_asan_runtime_mac.py View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Dirk Pranke
I think this is roughly what we were talking about? browser_tests seems to run w/ ...
4 years, 5 months ago (2016-07-23 01:12:14 UTC) #1
Alexander Potapenko
On 2016/07/23 01:12:14, Dirk Pranke wrote: > I think this is roughly what we were ...
4 years, 5 months ago (2016-07-25 08:38:11 UTC) #2
Dirk Pranke
4 years, 4 months ago (2016-07-25 20:29:45 UTC) #3
On 2016/07/25 08:38:11, Alexander Potapenko wrote:
> On 2016/07/23 01:12:14, Dirk Pranke wrote:
> > I think this is roughly what we were talking about? browser_tests seems to
run
> > w/ this.
> 
> Please take a look at build/mac/copy_asan_runtime_dylib.sh, which does exactly
> what you need.
> It may need to be changed to get the executable name and path from GN though.

Thanks for pointing this out. I don't think we can just substitute this script
directly in my patch,
as it's still executable_path-based (though I don't know if that's what you were
suggesting).

See my further comments on the bug, and let's work out a solution there.

Powered by Google App Engine
This is Rietveld 408576698