Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2180623002: Roll closure compiler (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-closure_chromium.org, extensions-reviews_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll closure compiler Change log: https://github.com/google/closure-compiler/compare/2f95290ea61dd4f1b5a3bf9d0fe3aa8e3244babf...c64418fd5518bb60aeb6a627d2bcc46a3d4be788 chrome_extensions.js: 754b5d249801020f5d71df9b7b576550f56972dc -> 462f6bc6508621ebeb7cf9a51fca7d069d2a7b85 R=dbeam@chromium.org TBR=sergeyu Committed: https://crrev.com/23b3ab864594f54a2e693f3bd8fc26e12542a2be Cr-Commit-Position: refs/heads/master@{#407318}

Patch Set 1 #

Patch Set 2 : Fix newly uncovered compilation error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3 lines) Patch
M remoting/webapp/js_proto/chrome_mocks.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/compiler/compiler.jar View Binary file 0 comments Download
M third_party/closure_compiler/externs/chrome_extensions.js View 2 chunks +70 lines, -1 line 0 comments Download
M third_party/closure_compiler/runner/runner.jar View Binary file 0 comments Download

Messages

Total messages: 11 (7 generated)
Dan Beam
lgtm
4 years, 5 months ago (2016-07-22 23:21:01 UTC) #2
dpapad
+sergeyu for remoting/ @dbeam: It turns out that the new compiler build caught a previous ...
4 years, 5 months ago (2016-07-22 23:50:38 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/23b3ab864594f54a2e693f3bd8fc26e12542a2be Cr-Commit-Position: refs/heads/master@{#407318}
4 years, 5 months ago (2016-07-23 00:36:59 UTC) #10
dpapad
4 years, 5 months ago (2016-07-23 00:37:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23b3ab864594f54a2e693f3bd8fc26e12542a2be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698