Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: ash/common/wm/workspace/workspace_layout_manager.cc

Issue 2180603002: Virtual keyboard - do not change work area of screen if in non-sticky mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Virtual keyboard - do not change work area of screen if in non-sticky mode Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/ash_switches.cc ('k') | ash/wm/workspace/workspace_layout_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/workspace/workspace_layout_manager.cc
diff --git a/ash/common/wm/workspace/workspace_layout_manager.cc b/ash/common/wm/workspace/workspace_layout_manager.cc
index 78de58d1124feea1bf024025791bbc070994b6db..e1a19c7f1765990432d44a3fbb2766a4fd59ac28 100644
--- a/ash/common/wm/workspace/workspace_layout_manager.cc
+++ b/ash/common/wm/workspace/workspace_layout_manager.cc
@@ -6,6 +6,7 @@
#include <algorithm>
+#include "ash/common/ash_switches.h"
#include "ash/common/session/session_state_delegate.h"
#include "ash/common/wm/always_on_top_controller.h"
#include "ash/common/wm/fullscreen_window_finder.h"
@@ -19,7 +20,9 @@
#include "ash/common/wm_shell.h"
#include "ash/common/wm_window.h"
#include "ash/common/wm_window_property.h"
+#include "base/command_line.h"
#include "ui/compositor/layer.h"
+#include "ui/keyboard/keyboard_controller.h"
#include "ui/keyboard/keyboard_controller_observer.h"
namespace ash {
@@ -130,6 +133,15 @@ void WorkspaceLayoutManager::SetChildBounds(WmWindow* child,
void WorkspaceLayoutManager::OnKeyboardBoundsChanging(
const gfx::Rect& new_bounds) {
+ // If new window behavior flag enabled and in non-sticky mode, do not change
+ // the work area.
+ bool change_work_area =
+ (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAshUseNewVKWindowBehavior) ||
+ keyboard::KeyboardController::GetInstance()->get_lock_keyboard());
+ if (!change_work_area)
+ return;
+
WmWindow* window = shell_->GetActiveWindow();
if (!window)
return;
« no previous file with comments | « ash/common/ash_switches.cc ('k') | ash/wm/workspace/workspace_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698