Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2180593002: mus: The window server needs to be able to write to the clipboard. (Closed)

Created:
4 years, 5 months ago by Elliot Glaysher
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: The window server needs to be able to write to the clipboard. This lifetime management for ClipboardImpl from service.cc to the window server. BUG=614037 Committed: https://crrev.com/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf Cr-Commit-Position: refs/heads/master@{#407308}

Patch Set 1 #

Patch Set 2 : gn check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M services/ui/service.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_server.h View 4 chunks +6 lines, -0 lines 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Elliot Glaysher
I'm going to try to *not* dump a +1500 line patch on you this time, ...
4 years, 5 months ago (2016-07-22 22:33:12 UTC) #4
sky
LGTM
4 years, 5 months ago (2016-07-22 23:39:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180593002/20001
4 years, 5 months ago (2016-07-22 23:43:19 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-23 00:05:30 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-23 00:08:13 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d6c8b29f6ccf357dfc9186f2ed9a4a22ec1b6cf
Cr-Commit-Position: refs/heads/master@{#407308}

Powered by Google App Engine
This is Rietveld 408576698