Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2180563002: Allow specifying alternate GN directories for run-perf-tests. (Closed)

Created:
4 years, 5 months ago by chrishtr
Modified:
4 years, 5 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow specifying alternate GN directories for run-perf-tests. Committed: https://crrev.com/25a7801b3059c1c1ceedabc9eb1ffeff75a1724f Cr-Commit-Position: refs/heads/master@{#407495}

Patch Set 1 #

Patch Set 2 : none #

Total comments: 2

Patch Set 3 : gc #

Patch Set 4 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
chrishtr
4 years, 5 months ago (2016-07-22 20:57:33 UTC) #3
qyearsley
LGTM, with nit and question https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py (right): https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py#newcode59 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:59: help="specify the target configuration ...
4 years, 5 months ago (2016-07-22 21:49:00 UTC) #4
chrishtr
https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py (right): https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py#newcode59 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:59: help="specify the target configuration to use (Debug/Release for gyp, ...
4 years, 5 months ago (2016-07-25 15:57:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180563002/60001
4 years, 5 months ago (2016-07-25 15:58:17 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-25 16:58:03 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 17:01:21 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/25a7801b3059c1c1ceedabc9eb1ffeff75a1724f
Cr-Commit-Position: refs/heads/master@{#407495}

Powered by Google App Engine
This is Rietveld 408576698