Allow specifying alternate GN directories for run-perf-tests.

Allow specifying alternate GN directories for run-perf-tests.

Committed: https://crrev.com/25a7801b3059c1c1ceedabc9eb1ffeff75a1724f
Cr-Commit-Position: refs/heads/master@{#407495}

[chrishtr, 2016-07-22 20:53:41]

Description was changed from

==========
none

BUG=
==========

to

==========
Allow specifying alternate GN directories for run-perf-tests.
==========

[chrishtr, 2016-07-22 20:57:32]

chrishtr@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2016-07-22 21:49:00]

LGTM, with nit and question

https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
(right):

https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:59:
help="specify the target configuration to use (Debug/Release for gyp, or another
subdirectory of out/ for GN)"),
Could also capitalize the s in "specify".

Also, in theory isn't it the case that you can use build directories called
"Debug" and "Release" with GN as well?

Would it be generally correct to say something like "Specify the target build
directory under src/out/."?

[chrishtr, 2016-07-25 15:57:40]

https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
(right):

https://codereview.chromium.org/2180563002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py:59:
help="specify the target configuration to use (Debug/Release for gyp, or another
subdirectory of out/ for GN)"),
On 2016/07/22 at 21:49:00, qyearsley wrote:
> Could also capitalize the s in "specify".
> 
> Also, in theory isn't it the case that you can use build directories called
"Debug" and "Release" with GN as well?
> 
> Would it be generally correct to say something like "Specify the target build
directory under src/out/."?

Done.

[chrishtr, 2016-07-25 15:58:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-25 15:58:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2180563002/#ps60001
(title: "none")

[commit-bot: I haz the power, 2016-07-25 15:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 16:58:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-25 17:01:19]

Description was changed from

==========
Allow specifying alternate GN directories for run-perf-tests.
==========

to

==========
Allow specifying alternate GN directories for run-perf-tests.

Committed: https://crrev.com/25a7801b3059c1c1ceedabc9eb1ffeff75a1724f
Cr-Commit-Position: refs/heads/master@{#407495}
==========

[commit-bot: I haz the power, 2016-07-25 17:01:21]

Patchset 4 (id:??) landed as
https://crrev.com/25a7801b3059c1c1ceedabc9eb1ffeff75a1724f
Cr-Commit-Position: refs/heads/master@{#407495}