Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issue 2180533002: Feature-detect browser for assignment to __proto__. (Closed)

Created:
3 years, 4 months ago by sra1
Modified:
3 years, 4 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Feature-detect browser for assignment to __proto__. Assigning to __proto__ is a fast way to stitch together a number of object literals into a prototype chain without copying all the properties. Unfortunately this leads to very slow execution on Firefox (and jsshell). So now we feature-detect Chrome (and d8) since that is the only browser we know currently can use the 'fast' startup path without penalizing subsequent performance. This speeds up some jsshell benchmarks by 30%. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/5923966da3388666f5d7692f2876666cad8b9255

Patch Set 1 #

Patch Set 2 : fix regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 1 chunk +22 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 3 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 4 months ago (2016-07-22 20:19:24 UTC) #2
Harry Terkelsen
lgtm
3 years, 4 months ago (2016-07-22 20:21:49 UTC) #3
sra1
3 years, 4 months ago (2016-07-23 18:42:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5923966da3388666f5d7692f2876666cad8b9255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698