Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 218053002: Friendship is not optimal. (Closed)

Created:
6 years, 9 months ago by ojan
Modified:
6 years, 8 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Friendship is not optimal. RenderLayer should not be friending a bunch of other classes. Better for the de facto public API to be the de jure public API. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170473

Patch Set 1 #

Patch Set 2 : Expose usedTransparency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -38 lines) Patch
M Source/core/rendering/RenderLayer.h View 1 6 chunks +31 lines, -37 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
ojan
6 years, 9 months ago (2014-03-29 02:05:29 UTC) #1
abarth-chromium
I feel like this CL is a moral statement. LGTM
6 years, 9 months ago (2014-03-29 02:14:07 UTC) #2
ojan
http://www.fimfiction.net/story/62074/friendship-is-optimal
6 years, 9 months ago (2014-03-29 02:15:35 UTC) #3
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 9 months ago (2014-03-29 02:15:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/218053002/1
6 years, 9 months ago (2014-03-29 02:15:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 02:22:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-29 02:22:39 UTC) #7
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 8 months ago (2014-03-31 17:25:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/218053002/20001
6 years, 8 months ago (2014-03-31 17:25:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 17:37:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-03-31 17:37:58 UTC) #11
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 8 months ago (2014-03-31 17:41:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/218053002/20001
6 years, 8 months ago (2014-03-31 17:42:04 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 18:39:46 UTC) #14
Message was sent while issue was closed.
Change committed as 170473

Powered by Google App Engine
This is Rietveld 408576698