Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2180513002: Fix MB configs for public PGO builders. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MB configs for public PGO builders. The public PGO builders do not do chrome-branded builds, so can't reuse the existing 'official' mixin and need to split out is_official_build from is_chrome_branded. TBR=sebmarchand@chromium.org NOTRY=true BUG=595947 Committed: https://crrev.com/9ef9d8e872aaac97e62099495d5d1c8d9a61d8f3 Cr-Commit-Position: refs/heads/master@{#407230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
skipping the trybots since we don't have any trybots that would be affected by this.
4 years, 5 months ago (2016-07-22 19:18:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180513002/1
4 years, 5 months ago (2016-07-22 19:19:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 19:25:18 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 19:26:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ef9d8e872aaac97e62099495d5d1c8d9a61d8f3
Cr-Commit-Position: refs/heads/master@{#407230}

Powered by Google App Engine
This is Rietveld 408576698