Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 2180503002: Add destination color space to AsFPArgs. Eliminates last XFORMTODO. (Closed)

Created:
4 years, 5 months ago by Brian Osman
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add destination color space to AsFPArgs. Eliminates last XFORMTODO. This is going to be needed in many more places as I finish connecting the dots. Even better - I'd like to switch to a world where SkColorSpace != nullptr is the only signal we use for gamma-correct rendering, so I can eliminate SkSourceGammaTreatment and SkSurfaceProps::isGammaCorrect. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180503002 Committed: https://skia.googlesource.com/skia/+/1638c0deea80e4a580fe43babeb04279dd163e98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -52 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/constcolorprocessor.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 17 chunks +38 lines, -20 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 8 chunks +13 lines, -6 lines 0 comments Download
M src/gpu/SkGrPriv.h View 5 chunks +8 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years, 5 months ago (2016-07-22 19:12:24 UTC) #5
bsalomon
lgtm
4 years, 5 months ago (2016-07-22 21:18:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180503002/1
4 years, 5 months ago (2016-07-25 11:41:09 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 12:12:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1638c0deea80e4a580fe43babeb04279dd163e98

Powered by Google App Engine
This is Rietveld 408576698