Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2180453002:
Add a sprite edge bleed test (Closed)
DescriptionAdd a sprite edge bleed test
We don't have good coverage for sprite bleeds.
Add a layout test which also runs for virtual/gpu-rasterization/.
TEST=fast/images/sprite-no-bleed.html
R=junov@chromium.org,schenney@chromium.org
Committed: https://crrev.com/24420dc04fe8ee09679398cea8c7b05b7cbbe4eb
Cr-Commit-Position: refs/heads/master@{#407473}
Patch Set 1 #Patch Set 2 : convert to pixel test #Patch Set 3 : virtual/gpu-rasterization/ expectation #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a sprite edge bleed test BUG= ========== to ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization. TEST=fast/images/sprite-no-bleed.html ==========
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization. TEST=fast/images/sprite-no-bleed.html ========== to ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization/. TEST=fast/images/sprite-no-bleed.html R=junov@chromium.org,schenney@chromium.org ==========
fmalita@chromium.org changed reviewers: + junov@chromium.org, schenney@chromium.org
Inspired by the discussion @ http://crrev.com/2167023004/, I ran a quick test forcing kFast_SrcRectConstraint on everything - and it passed with flying colors: https://codereview.chromium.org/2173083002/ But I could trigger local side effects (edge bleeds) with Ganesh, which means we don't have any layout test coverage for kStrict_SrcRectConstraint. Adding a test to rectify the situation. (I tried to make it a ref-test in PS#1, but there are minor edge variations with Ganesh/Mesa: https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Do you need more expectations? Otherwise it's great to get this coverage.
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
On 2016/07/22 19:59:42, Stephen Chennney wrote: > Do you need more expectations? Otherwise it's great to get this coverage. Yeah, needs a virtual/gpu-rasterization/ entry also. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization/. TEST=fast/images/sprite-no-bleed.html R=junov@chromium.org,schenney@chromium.org ========== to ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization/. TEST=fast/images/sprite-no-bleed.html R=junov@chromium.org,schenney@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization/. TEST=fast/images/sprite-no-bleed.html R=junov@chromium.org,schenney@chromium.org ========== to ========== Add a sprite edge bleed test We don't have good coverage for sprite bleeds. Add a layout test which also runs for virtual/gpu-rasterization/. TEST=fast/images/sprite-no-bleed.html R=junov@chromium.org,schenney@chromium.org Committed: https://crrev.com/24420dc04fe8ee09679398cea8c7b05b7cbbe4eb Cr-Commit-Position: refs/heads/master@{#407473} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/24420dc04fe8ee09679398cea8c7b05b7cbbe4eb Cr-Commit-Position: refs/heads/master@{#407473}
Message was sent while issue was closed.
excellent idea. lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
