Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2180433002: Remove a pointless assert that fails with overflowed values (Closed)

Created:
4 years, 5 months ago by Stephen Chennney
Modified:
4 years, 5 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a pointless assert that fails with overflowed values It turns out that roundedIntPoint(LayoutUnit::max()) != LayoutUNit::max() so disable the assert in BackgroundImageGeometry that is really just checking that we have pixel snapped the phase. We don't check any other values for pixel snapping, so there's no reason to keep checking phase. And there's no danger to having an unrounded value here. Nothing breaks. R=fmalita@chromium.org BUG=626745 Committed: https://crrev.com/96fad00d9606b2bdd89e3477387bad1d6bd8ba87 Cr-Commit-Position: refs/heads/master@{#407255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Stephen Chennney
Just to make clusterfuzz shut up.
4 years, 5 months ago (2016-07-22 18:09:22 UTC) #1
f(malita)
lgtm
4 years, 5 months ago (2016-07-22 18:23:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180433002/1
4 years, 5 months ago (2016-07-22 18:23:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 20:49:07 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 20:50:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96fad00d9606b2bdd89e3477387bad1d6bd8ba87
Cr-Commit-Position: refs/heads/master@{#407255}

Powered by Google App Engine
This is Rietveld 408576698