Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218043002: Mojo: Move public/environment to public/cpp/environment. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move public/environment to public/cpp/environment. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260362

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -407 lines) Patch
M mojo/bindings/js/support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/async_waiter_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/buffer_tls.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_async_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/bindings/lib/DEPS View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/bindings/lib/buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/connector.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/array_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/connector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/remote_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/request_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/sample_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/type_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/environment/buffer_tls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/environment/default_async_waiter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/environment/environment.h View 2 chunks +3 lines, -3 lines 0 comments Download
A mojo/public/cpp/environment/lib/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + mojo/public/cpp/environment/lib/buffer_tls.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/cpp/environment/lib/buffer_tls_setup.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/environment/lib/default_async_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/cpp/environment/lib/environment.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/cpp/environment/tests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/public/environment/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/public/environment/buffer_tls.h View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/public/environment/default_async_waiter.h View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/public/environment/environment.h View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/public/environment/lib/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/public/environment/lib/buffer_tls.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/public/environment/lib/buffer_tls_setup.h View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/public/environment/lib/default_async_waiter.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D mojo/public/environment/lib/environment.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/public/environment/tests/async_waiter_unittest.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M mojo/public/gles2/gles2_cpp.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-29 01:35:43 UTC) #1
darin (slow to review)
LGTM
6 years, 9 months ago (2014-03-29 03:29:39 UTC) #2
viettrungluu
6 years, 9 months ago (2014-03-29 04:28:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r260362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698