Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2180423005: Remove unnecessary eager finalization of PingLoaders. (Closed)

Created:
4 years, 4 months ago by sof
Modified:
4 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary eager finalization of PingLoaders. A PingLoader instance controls its own lifetime, releasing its self-keepalive reference upon completion of the load request. At that time it also lets go of its loader object (and stops the timer), hence there's no need to eagerly finalize this object -- it serves no real purpose. R= BUG= Committed: https://crrev.com/09d1e98f310cb1725bd97fa556fcb7298613e78a Cr-Commit-Position: refs/heads/master@{#408417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look.
4 years, 4 months ago (2016-07-28 15:06:10 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-07-28 15:06:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180423005/1
4 years, 4 months ago (2016-07-28 15:42:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 17:29:02 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:32:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09d1e98f310cb1725bd97fa556fcb7298613e78a
Cr-Commit-Position: refs/heads/master@{#408417}

Powered by Google App Engine
This is Rietveld 408576698