Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Issue 2180383003: Turn on flags to enforce SK_API. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Turn on flags to enforce SK_API. These flags hide symbols that are not marked with SK_API when linked into a shared library. There's nominally no effect on static linking, but I'm pretty sure the Mac linker takes some advantage of this too to run faster. This makes component-build DM no longer link: it uses many non SK_API APIs. Fiddle in contrast is just fine with our public APIs, so no need to restrict that. It'll be fun finding out which of our other tools go which ways. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180383003 Committed: https://skia.googlesource.com/skia/+/8796ff1fbcee33006b62c1df6f1573510d6e4e7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M BUILD.gn View 1 chunk +22 lines, -20 lines 0 comments Download
M gn/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 4 months ago (2016-07-27 21:03:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180383003/1
4 years, 4 months ago (2016-07-27 21:04:00 UTC) #5
jcgregorio
lgtm
4 years, 4 months ago (2016-07-27 21:07:42 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 21:59:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8796ff1fbcee33006b62c1df6f1573510d6e4e7f

Powered by Google App Engine
This is Rietveld 408576698