Increase line spacing for long descriptions in Clear Browsing Data

Increase line spacing for long descriptions in Clear Browsing Data

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0e125a5df94296ca60346bb5014b29a43f0e249d
Cr-Commit-Position: refs/heads/master@{#408223}

[jrummell, 2016-07-26 21:57:24]

Description was changed from

==========
Increase line spacing for long descriptions in Clear Browsing Data

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
==========

to

==========
Increase line spacing for long descriptions in Clear Browsing Data

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jrummell, 2016-07-26 22:05:13]

jrummell@chromium.org changed reviewers:
+ msramek@chromium.org, stevenjb@chromium.org

[jrummell, 2016-07-26 22:05:14]

PTAL. UI review of the canary build asks for increased line spacing between the
text. A picture of the dialog with the extra spacing is
https://drive.google.com/open?id=0Bw1Ws6OM7ISEeVZ0WmU0d1M3d3c. (Previous is
https://drive.google.com/open?id=0Bw1Ws6OM7ISESzJsM21qamh2Rjg).

[msramek, 2016-07-26 22:12:38]

LGTM, as I was on that email thread.

[stevenjb, 2016-07-27 16:48:28]

lgtm

[jrummell, 2016-07-27 19:26:03]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:26:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:17:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 20:20:31]

Description was changed from

==========
Increase line spacing for long descriptions in Clear Browsing Data

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Increase line spacing for long descriptions in Clear Browsing Data

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0e125a5df94296ca60346bb5014b29a43f0e249d
Cr-Commit-Position: refs/heads/master@{#408223}
==========

[commit-bot: I haz the power, 2016-07-27 20:20:32]

Patchset 1 (id:??) landed as
https://crrev.com/0e125a5df94296ca60346bb5014b29a43f0e249d
Cr-Commit-Position: refs/heads/master@{#408223}

[Dan Beam, 2016-07-29 00:32:55]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-29 00:32:56]

is this handled in md-settings?

[jrummell, 2016-07-29 01:45:43]

md-settings has the additional text on a separate line already. Typically the
string didn't get long enough to wrap around. I just tried modifying
generated_resources.grd with a bunch of extra text, and it wraps around fine.