Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/compiler/verifier.cc

Issue 2180373005: [turbofan] Add support for String.prototype.charCodeAt/charAt. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 CheckUpperIs(node, Type::Number()); 806 CheckUpperIs(node, Type::Number());
807 break; 807 break;
808 case IrOpcode::kStringEqual: 808 case IrOpcode::kStringEqual:
809 case IrOpcode::kStringLessThan: 809 case IrOpcode::kStringLessThan:
810 case IrOpcode::kStringLessThanOrEqual: 810 case IrOpcode::kStringLessThanOrEqual:
811 // (String, String) -> Boolean 811 // (String, String) -> Boolean
812 CheckValueInputIs(node, 0, Type::String()); 812 CheckValueInputIs(node, 0, Type::String());
813 CheckValueInputIs(node, 1, Type::String()); 813 CheckValueInputIs(node, 1, Type::String());
814 CheckUpperIs(node, Type::Boolean()); 814 CheckUpperIs(node, Type::Boolean());
815 break; 815 break;
816 case IrOpcode::kStringCharCodeAt:
817 // (String, Unsigned32) -> UnsignedSmall
818 CheckValueInputIs(node, 0, Type::String());
819 CheckValueInputIs(node, 1, Type::Unsigned32());
820 CheckUpperIs(node, Type::UnsignedSmall());
821 break;
816 case IrOpcode::kStringFromCharCode: 822 case IrOpcode::kStringFromCharCode:
817 // Number -> String 823 // Number -> String
818 CheckValueInputIs(node, 0, Type::Number()); 824 CheckValueInputIs(node, 0, Type::Number());
819 CheckUpperIs(node, Type::String()); 825 CheckUpperIs(node, Type::String());
820 break; 826 break;
821 case IrOpcode::kReferenceEqual: { 827 case IrOpcode::kReferenceEqual: {
822 // (Unique, Any) -> Boolean and 828 // (Unique, Any) -> Boolean and
823 // (Any, Unique) -> Boolean 829 // (Any, Unique) -> Boolean
824 CheckUpperIs(node, Type::Boolean()); 830 CheckUpperIs(node, Type::Boolean());
825 break; 831 break;
(...skipping 707 matching lines...) Expand 10 before | Expand all | Expand 10 after
1533 replacement->op()->EffectOutputCount() > 0); 1539 replacement->op()->EffectOutputCount() > 0);
1534 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1540 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1535 replacement->opcode() == IrOpcode::kFrameState); 1541 replacement->opcode() == IrOpcode::kFrameState);
1536 } 1542 }
1537 1543
1538 #endif // DEBUG 1544 #endif // DEBUG
1539 1545
1540 } // namespace compiler 1546 } // namespace compiler
1541 } // namespace internal 1547 } // namespace internal
1542 } // namespace v8 1548 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698