Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2180373005: [turbofan] Add support for String.prototype.charCodeAt/charAt. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for String.prototype.charCodeAt/charAt. Introduce an appropriate StringCharCodeAt simplified operator and use that to optimize the String.prototype.charCodeAt/.charAt builtins. R=epertoso@chromium.org Committed: https://crrev.com/5340f767584749d604a9ce1abc9b14547fcf0e35 Cr-Commit-Position: refs/heads/master@{#38106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -89 lines) Patch
M src/compiler/access-builder.h View 1 chunk +27 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 2 chunks +72 lines, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +270 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 5 chunks +132 lines, -0 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 3 chunks +81 lines, -84 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-27 13:01:59 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-07-27 14:53:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180373005/1
4 years, 4 months ago (2016-07-27 17:24:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:26:30 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:30:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5340f767584749d604a9ce1abc9b14547fcf0e35
Cr-Commit-Position: refs/heads/master@{#38106}

Powered by Google App Engine
This is Rietveld 408576698