chrome/browser/metrics/sampling_metrics_provider.h - Issue 2180373003: Adding reporting of metrics sampling rate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/metrics/sampling_metrics_provider.h

Issue 2180373003: Adding reporting of metrics sampling rate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding reporting of sampling rate. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_METRICS_SAMPLING_METRICS_PROVIDER_H_

	6 #define CHROME_BROWSER_METRICS_SAMPLING_METRICS_PROVIDER_H_

	7

	8 #include "components/metrics/metrics_provider.h"

	9

	10 namespace metrics {
	Alexei Svitkine (slow) 2016/08/01 15:49:56 Nit: Add an empty line. Nit: Add an empty line. jwd 2016/08/01 16:45:29 Done. Show quoted text On 2016/08/01 15:49:56, Alexei Svitkine (slow) wrote: > Nit: Add an empty line. Done.
	11 class SamplingMetricsProvider : public MetricsProvider {

	12 public:

	13 SamplingMetricsProvider();

	14 ~SamplingMetricsProvider() override;

	15

	16 // MetricsProvider:
	Alexei Svitkine (slow) 2016/08/01 15:49:56 Add private: before this. Add private: before this. jwd 2016/08/01 16:45:29 Done. Show quoted text On 2016/08/01 15:49:56, Alexei Svitkine (slow) wrote: > Add private: before this. Done.
	17 void ProvideGeneralMetrics(ChromeUserMetricsExtension* uma_proto) override;

	18

	19 DISALLOW_COPY_AND_ASSIGN(SamplingMetricsProvider);

	20 };

	21

	22 } // namespace metrics

	23

	24 #endif // CHROME_BROWSER_METRICS_SAMPLING_METRICS_PROVIDER_H_

OLD	NEW