Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: chrome/browser/metrics/sampling_metrics_provider.cc

Issue 2180373003: Adding reporting of metrics sampling rate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Alexei's comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/metrics/sampling_metrics_provider.h"
6
7 #include "base/metrics/sparse_histogram.h"
8 #include "chrome/browser/metrics/chrome_metrics_services_manager_client.h"
9 #include "components/metrics/metrics_provider.h"
10
11 namespace metrics {
12
13 SamplingMetricsProvider::SamplingMetricsProvider() {}
14 SamplingMetricsProvider::~SamplingMetricsProvider() {}
15
16 void SamplingMetricsProvider::ProvideGeneralMetrics(
Alexei Svitkine (slow) 2016/08/01 17:23:51 Maybe this should be ProvideStabilityMetrics - so
jwd 2016/08/01 18:57:14 Ok, so UMA_STABILITY_HISTOGRAM_ENUMERATION will ju
Alexei Svitkine (slow) 2016/08/01 18:59:02 I think we should still use a sparse histogram. Yo
jwd 2016/08/01 20:11:35 Done.
17 ChromeUserMetricsExtension* uma_proto) {
18 UMA_HISTOGRAM_SPARSE_SLOWLY(
Alexei Svitkine (slow) 2016/08/01 17:23:51 Should we just not log this for users who are not
jwd 2016/08/01 18:57:14 Done.
19 "UMA.SamplingRatePerMille",
20 ChromeMetricsServicesManagerClient::GetSamplingRatePerMille());
21 }
22
23 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698