Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2180363002: Avoid using call-through stub on calls to fields. (Closed)

Created:
4 years, 4 months ago by sra1
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid using call-through stub on calls to fields. This usually removes the demand for the call-through stub and sometimes enables optimizations on the field load, e.g.: WhereIterator: { "^": "Iterator;_iterator,_f", moveNext$0: function() { for (var t1 = this._iterator; t1.moveNext$0();) if (this._f$1(t1.get$current()) === true) return true; return false; }, _f$1: function(arg0) { return this._f.call$1(arg0); } ... --> WhereIterator: { "^": "Iterator;_iterator,_f", moveNext$0: function() { var t1, t2; for (t1 = this._iterator, t2 = this._f; t1.moveNext$0();) if (t2.call$1(t1.get$current()) === true) return true; return false; }, ... BUG= https://github.com/dart-lang/sdk/issues/22197 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9d5fd9d5bd9dea0098a8f49a87300ab578eb765c

Patch Set 1 : #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +26 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/elide_callthrough_stub_test.dart View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
sra1
4 years, 4 months ago (2016-07-26 21:02:52 UTC) #6
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-07-26 22:13:00 UTC) #7
sra1
4 years, 4 months ago (2016-07-27 01:02:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
9d5fd9d5bd9dea0098a8f49a87300ab578eb765c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698