Add size_t length argument to v8::ArrayBuffer::Allocator::Free.

src/d8.cc

Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index e66a2ece600bb0ab54da79510cb4a7db96f75d89..016ce2d3720de3336258ab09b391c5d0bcdb400e 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1635,7 +1635,8 @@ class ShellArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
   virtual void* AllocateUninitialized(size_t length) {
     return malloc(length);
   }
-  virtual void Free(void* data) { free(data); }
+  virtual void Free(void* data, size_t) { free(data); }
+  virtual void Free(void* data) { UNREACHABLE(); }

[Dmitry Lomov (no reviews), 2013/08/02 11:32:57]

The second overload is a workaround for gcc warning  ‘virtual void
v8::ArrayBuffer::Allocator::Free(void*)’ was hidden
by ‘virtual void v8::ShellArrayBufferAllocator::Free(void*, size_t)’
[-Werror=overloaded-virtual].

It _looks like_ this is not an error for Blink/chromium (as in, I was able to
build blink and chromium agains this patch on Linux). 
Bug https://code.google.com/p/v8/issues/detail?id=2823 tracks cleaning up the
interface

[Michael Starzinger, 2013/08/02 12:13:06]

nit: Let's add a TODO here referring to the issue number. Because removing the
method from the interface will not be enough to find this override.

 };